Skip to content

feat(api)!: add toolset prompts infrastructure#581

Merged
nader-ziada merged 2 commits intocontainers:mainfrom
nader-ziada:2-toolset-prompts
Dec 15, 2025
Merged

feat(api)!: add toolset prompts infrastructure#581
nader-ziada merged 2 commits intocontainers:mainfrom
nader-ziada:2-toolset-prompts

Conversation

@nader-ziada
Copy link
Copy Markdown
Collaborator

Fixes: #556

Enable toolset implementers to define MCP prompts programmatically as part of their toolset definition.

  • Add GetPrompts() method to Toolset interface
  • Collect prompts from all enabled toolsets
  • Merge config and toolset prompts (config takes precedence)
  • Add disable_toolset_prompts configuration option
  • Update all existing toolsets to implement GetPrompts()

docs/PROMPTS.md Outdated
Comment on lines +111 to +112
```toml
disable_toolset_prompts = true
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nader-ziada will this be a global option, or a per-toolset option?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global option currently

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I included this in #556

Disabling Toolset Prompts

Administrators can disable all toolset-defined prompts via configuration, using only config-defined prompts:

based on what Nader initially implemented in #510

IMO maybe we SHOULD NOT provide this option at all (prompts don't have any involuntary impact on the LLM behavior or consume context-window tokens)

OR if you consider this of value, provide a consistent implementation with what we have for tools (EnabledTools / DisabledTools).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the sake of simplicity, will remove the flag completely

Enable toolset implementers to define MCP prompts programmatically
as part of their toolset definition.

- Add GetPrompts() method to Toolset interface
- Collect prompts from all enabled toolsets
- Merge config and toolset prompts (config takes precedence)
- Add disable_toolset_prompts configuration option
- Update all existing toolsets to implement GetPrompts()

Signed-off-by: Nader Ziada <nziada@redhat.com>
@manusa manusa changed the title add toolset prompts infrastructure feat(api): add toolset prompts infrastructure Dec 12, 2025
@manusa manusa changed the title feat(api): add toolset prompts infrastructure feat(api)!: add toolset prompts infrastructure Dec 12, 2025
@manusa manusa added this to the 0.1.0 milestone Dec 12, 2025
Signed-off-by: Nader Ziada <nziada@redhat.com>
@manusa manusa self-requested a review December 15, 2025 14:35
Copy link
Copy Markdown
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa requested a review from Cali0707 December 15, 2025 14:43
@nader-ziada nader-ziada merged commit c28c02e into containers:main Dec 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] Toolset-defined prompt templates

3 participants